[ListSubheader] Reduce specificity of typescript type #17715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakulstra
changed the title
|
No bundle size changes comparing 6b9ecbe...f4cd998 |
eps1lon
previously requested changes
Oct 7, 2019
oliviertassinari
added
PR: needs revision
|
I think the issue here is the previous |
|
sorry for not getting back at this 😞 as a heads up - I will try to fix it on Friday |
|
@eps1lon could you recheck this? |
oliviertassinari
removed
the
PR: needs revision
oliviertassinari
approved these changes
Oct 18, 2019
|
@sakulstra Thanks for sticking with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked trough the other components and most of them just have a less specific type (the one I used here as well).